-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: Add Scalebar support for subcoordinate_y plots #6403
Conversation
182cec0
to
9d18fd2
Compare
3f9bb97
to
3dbaa42
Compare
3dbaa42
to
8b2b8f2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6403 +/- ##
==========================================
+ Coverage 88.48% 88.50% +0.01%
==========================================
Files 323 323
Lines 68469 68563 +94
==========================================
+ Hits 60588 60681 +93
- Misses 7881 7882 +1 ☔ View full report in Codecov by Sentry. |
@mattpap, is there any way to keep the label text horizontal and put it to the side of a vertically oriented scale bar? Right now, when the text is bigger than the bar, the text will offset the positioning of the bar. |
0a03831
to
456e0f0
Compare
Currently label orientation is "idiomatic" and not configurable, but I can add an option for this.
I suppose that a bug on its own. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just with a minor comment/suggestion about getting the renderer.
Resolves #6292
Example: