-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iris interface handles standard constructors enabling unit tests #709
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -404,7 +404,7 @@ def test_dataset_double_zip_init(self): | |
|
||
class GridDatasetTest(HomogeneousColumnTypes, ComparisonTestCase): | ||
""" | ||
Test of the NdDataset interface (mostly for backwards compatibility) | ||
Test of the Grid array interface | ||
""" | ||
|
||
def setUp(self): | ||
|
@@ -480,3 +480,36 @@ def test_dataset_sort_vdim_hm(self): | |
def test_dataset_groupby(self): | ||
self.assertEqual(self.dataset_hm.groupby('x').keys(), list(self.xs)) | ||
|
||
|
||
|
||
class IrisDatasetTest(GridDatasetTest): | ||
""" | ||
Tests for Iris interface | ||
""" | ||
|
||
def setUp(self): | ||
import iris | ||
self.restore_datatype = Dataset.datatype | ||
Dataset.datatype = ['cube'] | ||
self.data_instance_type = iris.cube.Cube | ||
self.init_data() | ||
|
||
# Disabled tests for NotImplemented methods | ||
def test_dataset_add_dimensions_values_hm(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume you are doing this to disable some of the inherited tests. A docstring explaining why these tests are not enable would be good... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, sounds good. They should eventually be remove once those methods are implemented. |
||
pass | ||
|
||
def test_dataset_sort_vdim_hm(self): | ||
pass | ||
|
||
def test_dataset_1D_reduce_hm(self): | ||
pass | ||
|
||
def test_dataset_2D_reduce_hm(self): | ||
pass | ||
|
||
def test_dataset_2D_aggregate_partial_hm(self): | ||
pass | ||
|
||
def test_dataset_sample_hm(self): | ||
pass | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this must be related to the bounds issue I noticed in the tests (see below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, so far we've used non-inclusive upper bounds in holoviews, so this just makes it consistent. Might be worth having the discussion which is more appropriate, since iris and xarray both seem to use inclusive bounds.