Fixes for bokeh 0.12 compatibility #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
changed the title
philippjfr
force-pushed
the
bokeh_0.12_compatibility
branch
from
f5fd303
to
dfffcb7
Compare
philippjfr
force-pushed
the
bokeh_0.12_compatibility
branch
from
dfffcb7
to
049cb30
Compare
|
Ready to merge. |
|
I'm happy to see 0.10 compatibility dropped and I like seeing Javascript removed. Unifying the approach (and also getting a speed up!) sounds great. Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says this PR makes HoloViews compatible with the upcoming bokeh 0.12 release. Since bokeh is going through rapid development cycles and we do not want to accumulate endless compatibility layers we are also dropping compatibility with 0.10 in this PR. The major component of this PR is in changing the way JSON patches are computed when using the widgets and callbacks, which has now been unified to use the same approach everywhere, bypassing the relatively slow patch diffing that bokeh uses by default and also dropping various hacks previously added to make things work across 0.10 and 0.11. This PR also does not yet add support for any of the new features in bokeh 0.12. Those should follow in future PRs; for now this PR just makes sure all existing functionality continues to work.