Fixed bug computing extents of mpl SpreadPlot #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed the updated test date, rebuilding now. Then ready to merge. |
|
Had to rebuild the test data hence why the push build is failing. Otherwise ready to merge. |
|
Looks good! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extent of Spread Elements wasn't being correctly computed in matplotlib. This provides a safe (but not perfect) implementation, computing the absolute largest possible extent, because there is no direct way to compute it precisely across multiple frames at the moment, something that will only become possible when we make the normalization system more general.