Widgets ignore dimension streams #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -824,6 +832,16 @@ def wrap_tuple_streams(unwrapped, kdims, streams): | |||
| return tuple(substituted) | |||
|
|
|||
|
|
|||
| def drop_streams(streams, keys, kdims): | |||
| """ | |||
| Drop any dimensionsed streams from the keys and kdims. | |||
There was a problem hiding this comment.
Typo in 'dimensioned' and maybe add a line saying what it returns.
There was a problem hiding this comment.
I still think it is a little odd to put the keys (typically a very long list) before the kdims (much shorter). The order that feels (slightly) more natural to me for the signature is (streams, kdims, keys). As there can be a long list of streams, the next best is probably (kdims, streams, keys).
Just a minor point that you may ignore if you wish!
|
Tests have passed so I will merge it now. I'm excited to try it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Widgets now ignore dimensions which are defined through a stream ensuring that only widgets for non-stream dimensions are displayed.