Overlay collate #952
Merged
Overlay collate #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
overlay_collate
branch
from
416c1fa
to
f5c9e2f
Compare
|
Having things work but issue a warning is something we already partially implemented. This PR completes that - or at least, I can't currently think of any other similar collation+warning scenario. The increased efficiency is also nice! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #530, which suggested that creating an Overlay of HoloMaps to make it easy to declare certain datastructures. This PR reimplements the
Layout.from_valuesmethod to be more efficient by not creating a bunch of intermediate objects, which also makes it possible to create an Overlay of HoloMaps and GridSpaces. Additionally it adds a trivialcollateimplementation which simply mirrors the oldfrom_valuesimplementation by reducing all the objects with the__mul__operator. Finally it sets up Overlays of HoloMaps and GridSpaces to be automatically collated and issue a warning like we already do for other invalid nesting structures.