Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover_tooltips, hover_formatters, hover_mode #1385

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Jul 30, 2024

Adds opts from holoviz/holoviews#6180

Don't think a test is required since it's just adding plot_opts?

@ahuang11 ahuang11 requested a review from maximlt July 30, 2024 19:50
@ahuang11 ahuang11 changed the title Add hover_tooltips Add hover_tooltips, hover_formatters, hover_mode Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (6c96c7e) to head (0149ef9).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
+ Coverage   87.39%   88.86%   +1.47%     
==========================================
  Files          50       51       +1     
  Lines        7490     7500      +10     
==========================================
+ Hits         6546     6665     +119     
+ Misses        944      835     -109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 requested a review from droumis August 5, 2024 18:48
Copy link
Member

@droumis droumis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as a monitor rather than a maintainer for hvPlot, I'm not sure if my approval is sufficient to merge, so you might want to wait for Maxime to review or ask another maintainer.

@ahuang11 ahuang11 requested a review from hoxbro August 6, 2024 21:53
@ahuang11 ahuang11 merged commit d173da8 into main Aug 7, 2024
9 checks passed
@ahuang11 ahuang11 deleted the add_hover_tooltips branch August 7, 2024 16:21
@maximlt
Copy link
Member

maximlt commented Aug 14, 2024

I've got a few comments.

Doesn't hover_mode duplicate what is already possible with setting hover to e.g. 'vline'? This was added in #493 but never documented I believe.


Don't think a test is required since it's just adding plot_opts?

Adding tests is pretty much always worth in my opinion, in particular when they're easy to write.


I would suggest alphabetically ordering the new hover_* parameters in the signature, docstring, and doc.


We need to find a way to better document these sorts of options. As it stands, I don't think the docs provide sufficient information for users to leverage these new parameters.

@ahuang11 ahuang11 mentioned this pull request Aug 14, 2024
@ahuang11
Copy link
Collaborator Author

Filed as an issue for follow up
#1394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants