-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten op_args to be able to find nested widgets #699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks!
9814feb
to
b82d43c
Compare
The error could be recreated with import xarray as xr
import hvplot.xarray # noqa
import panel.widgets as pnw
ds = xr.tutorial.load_dataset('air_temperature')
diff = ds.air.interactive.sel(time=pnw.DiscreteSlider) - ds.air.mean('time')
kind = pnw.Select(options=['contour', 'contourf', 'image'])
diff.hvplot(cmap='RdBu_r', clim=(-20, 20), kind=kind) The custom flatten function will be added with holoviz/holoviews#5184. Alternative I could also add it to hvplot. |
If I understand correctly, I think having it in HoloViews should be sufficient; no need to duplicate that. |
You understood it correctly. |
With the release of Holoviews 1.14.8, can I get one to rerun the tests? |
The error do not seem to be related to my changes. As when I run it locally on master it freezes at Log from
|
if hd.ds_version < '0.12.0': |
a75cc49
to
fbcc04e
Compare
Thanks, @hoxbro for the cool new functionality, and thanks @sophiamyang for reporting the issue and inspiring him to do this work! |
Fixes #697
Needs holoviz/holoviews#5184 to work