Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting of Widget variable default #263

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Conversation

philippjfr
Copy link
Member

Previously we were setting the non-existent default parameter on the Panel widgets resulting in the default being simply ignored.

@codecov-commenter
Copy link

Codecov Report

Merging #263 (9766b86) into master (1f45403) will decrease coverage by 0.09%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   65.34%   65.25%   -0.10%     
==========================================
  Files          57       57              
  Lines        5474     5477       +3     
==========================================
- Hits         3577     3574       -3     
- Misses       1897     1903       +6     
Impacted Files Coverage Δ
lumen/variables/base.py 73.54% <16.66%> (-3.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f45403...9766b86. Read the comment docs.

@philippjfr philippjfr merged commit 02650f2 into master Mar 25, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants