Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support async callbacks #441

Merged
merged 4 commits into from
Feb 2, 2023
Merged

Support async callbacks #441

merged 4 commits into from
Feb 2, 2023

Conversation

philippjfr
Copy link
Member

Ensures all callbacks provided to the config can be asynchronous.

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Merging #441 (71a70c7) into main (1181e11) will decrease coverage by 0.02%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   69.29%   69.28%   -0.02%     
==========================================
  Files          76       76              
  Lines        8931     8928       -3     
==========================================
- Hits         6189     6186       -3     
  Misses       2742     2742              
Impacted Files Coverage Δ
lumen/dashboard.py 74.41% <33.33%> (+0.03%) ⬆️
lumen/util.py 66.51% <37.50%> (-0.59%) ⬇️
lumen/pipeline.py 64.61% <50.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 947fe74 into main Feb 2, 2023
@philippjfr philippjfr deleted the async_callbacks branch February 2, 2023 15:56
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants