Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_multi_select_double_click error #6902

Closed
cdeil opened this issue Jun 7, 2024 · 2 comments
Closed

test_multi_select_double_click error #6902

cdeil opened this issue Jun 7, 2024 · 2 comments

Comments

@cdeil
Copy link
Contributor

cdeil commented Jun 7, 2024

@hoxbro - I see this UI test error:

(base) panel $ pixi run test-ui
✨ Pixi task (_install-ui in test-ui): playwright install chromium

✨ Pixi task (test-ui in test-ui): pytest panel/tests/ui --ui --browser chromium -n logical --dist loadgroup --reruns 3 --reruns-delay 10
=================================================================================== test session starts ====================================================================================
platform darwin -- Python 3.12.3, pytest-7.4.4, pluggy-1.5.0
rootdir: /Users/cdeil/code/oss/panel
configfile: pyproject.toml
plugins: cov-5.0.0, github-actions-annotate-failures-0.2.0, playwright-0.5.0, rerunfailures-14.0, anyio-4.4.0, xdist-3.5.0, base-url-2.1.0, asyncio-0.23.6
asyncio: mode=Mode.AUTO
10 workers [529 items]  kipped                                                                                                                                                             
sssssssss.............s...........................................................................................................................................R......R.......... [ 33%]
......................R.........................................................................................................................R.x.R.xR.xx....R.................... [ 67%]
.......................x.....................R.xx..R.......x.....R.x.RR..........................xxx.xxRxxFxxxxxx..xxxxxx.xxxxx..........................................R.....RR..F [ 99%]
F..RF.                                                                                                                                                                               [100%]
========================================================================================= FAILURES =========================================================================================
______________________________________________________________________________ test_multi_select_double_click ______________________________________________________________________________
[gw5] darwin -- Python 3.12.3 /Users/cdeil/code/oss/panel/.pixi/envs/test-ui/bin/python3.12

page = <Page url='http://localhost:55237/'>

    def test_multi_select_double_click(page):
        clicks = []
        select = MultiSelect(options=['A', 'B', 'C'], on_double_click=clicks.append)
    
        serve_component(page, select)
    
        page.locator('option').nth(1).dblclick()
    
>       wait_until(lambda: clicks and clicks[0].option == 'B')
E       ValueError: `wait_until` callback must return None, True or False, returned []

panel/tests/ui/widgets/test_select.py:33: ValueError

Some others time out:

FAILED panel/tests/ui/widgets/test_select.py::test_multi_select_double_click - ValueError: `wait_until` callback must return None, True or False, returned []
FAILED panel/tests/ui/widgets/test_icon.py::test_toggle_icon_size - TimeoutError: wait_until timed out in 5000 milliseconds
FAILED panel/tests/ui/widgets/test_icon.py::test_toggle_icon_width_height - TimeoutError: wait_until timed out in 5000 milliseconds
FAILED panel/tests/ui/widgets/test_tabulator.py::test_tabulator_patch_no_height_resize - TimeoutError: wait_until timed out in 5000 milliseconds
FAILED panel/tests/ui/widgets/test_tabulator.py::test_tabulator_edit_event_and_header_filters - playwright._impl._errors.TimeoutError: Locator.fill: Timeout 20000ms exceeded.
================================= 5 failed, 481 passed, 11 skipped, 33 xfailed, 81 warnings, 18 rerun in 191.78s (0:03:11) ==================================
@hoxbro
Copy link
Member

hoxbro commented Jun 7, 2024

The error you is seeing is a bug and should be updated to wait_until(lambda: bool(clicks) and clicks[0].option == 'B')

Does the timeout error happen for the same tests when you rerun the code? Or is it a different test timing out?

Are you running on a slow connection internet connection or VPN?

@hoxbro hoxbro mentioned this issue Jun 10, 2024
@cdeil
Copy link
Contributor Author

cdeil commented Jun 15, 2024

Fixed in #6909

@cdeil cdeil closed this as completed Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants