Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-CI #6909

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Fix test-CI #6909

merged 4 commits into from
Jun 10, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jun 10, 2024

Conda-forge now has playwright, though they patched it to remove the download option, and it only works on the UNIX system for now. For now, I will keep using the one from the Microsoft channel. It does seem like the conda-forge equivalent is called python-playwright.

Also, fixing the error shown in #6902

I think the failing test in test_param_generator is because we don't have an event loop, which takes time to start on CI, therefore missing the wait_until time.

@hoxbro hoxbro changed the title Use playwright from microsoft channel Fix test-CI Jun 10, 2024
@hoxbro
Copy link
Member Author

hoxbro commented Jun 10, 2024

The failing holoviews test is because of changes made in holoviz/holoviews#6256

@hoxbro hoxbro marked this pull request as ready for review June 10, 2024 10:42
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (681ddc9) to head (feebdf3).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6909       +/-   ##
===========================================
+ Coverage   38.42%   81.56%   +43.13%     
===========================================
  Files         308      319       +11     
  Lines       45062    46915     +1853     
===========================================
+ Hits        17315    38264    +20949     
+ Misses      27747     8651    -19096     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro requested a review from philippjfr June 10, 2024 10:51
@philippjfr philippjfr merged commit c90ffd4 into main Jun 10, 2024
15 checks passed
@philippjfr philippjfr deleted the fix_test_ci branch June 10, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants