Set Tabulator to render into explicit popup container #7299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7299 +/- ##
===========================================
- Coverage 82.18% 71.78% -10.40%
===========================================
Files 337 336 -1
Lines 50380 50379 -1
===========================================
- Hits 41407 36167 -5240
- Misses 8973 14212 +5239 ☔ View full report in Codecov by Sentry. |
|
Seeing this problem for one of my examples in the original issue: |
|
Yep, seeing that too. Not sure what to do about it. |
|
What about making this setting an option for now? Or maybe document the behavior, as it can be enabled by the configuration directly: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely happy with this as the editor isn't aligned quite right but I played with all the options and couldn't find one that produced the correct result.
Fixes #7295