Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Tabulator to render into explicit popup container #7299

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philippjfr
Copy link
Member

Not entirely happy with this as the editor isn't aligned quite right but I played with all the options and couldn't find one that produced the correct result.

Fixes #7295

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.78%. Comparing base (d4f7d68) to head (ba47027).
Report is 5 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (d4f7d68) and HEAD (ba47027). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (d4f7d68) HEAD (ba47027)
14 5
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7299       +/-   ##
===========================================
- Coverage   82.18%   71.78%   -10.40%     
===========================================
  Files         337      336        -1     
  Lines       50380    50379        -1     
===========================================
- Hits        41407    36167     -5240     
- Misses       8973    14212     +5239     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro
Copy link
Member

hoxbro commented Sep 19, 2024

Seeing this problem for one of my examples in the original issue:
image

@philippjfr
Copy link
Member Author

Yep, seeing that too. Not sure what to do about it.

@hoxbro
Copy link
Member

hoxbro commented Sep 19, 2024

What about making this setting an option for now?

Or maybe document the behavior, as it can be enabled by the configuration directly: pn.widgets.Tabulator(... configuration={"popupContainer": True})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator list editor inside a template / jupyter lab will not stay fixed to the cell
2 participants