Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve notebook detection #5201

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Improve notebook detection #5201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
205487d
Improve VS Code notebook detection
hoxbro Jul 3, 2023
e2767bb
Improve colab notebook detection
hoxbro Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions panel/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -787,14 +787,11 @@ def _detect_comms(self, params):
return

# Try to detect environment so that we can enable comms
try:
import google.colab # noqa
if "google.colab" in sys.modules:
config.comms = "colab"
return
except ImportError:
pass

if "VSCODE_PID" in os.environ:
if "VSCODE_CWD" in os.environ or "VSCODE_PID" in os.environ:
config.comms = "vscode"
self._ignore_bokeh_warnings()
return
Expand Down