Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were hanging and it seems this was due to manually using the
serve
utility rather than using the more recentserve_and_wait
andserve_and_request
utilities.I'm still a little confused at the difference since internally those utilities don't do anything too different except for having logic to wait until the server is actually up and running before continuing with the test.The issue was that unless you explicitly provided a server_id to
get_server
the server_id instate._threads
would not match the server_id onstate._servers
, meaning that when it came time to shut down the threads/servers the recent changes I made to the clean up logic would never find the thread to shut down.