Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tests don't hang #6492

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Ensure tests don't hang #6492

merged 3 commits into from
Mar 14, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 14, 2024

Tests were hanging and it seems this was due to manually using the serve utility rather than using the more recent serve_and_wait and serve_and_request utilities.

I'm still a little confused at the difference since internally those utilities don't do anything too different except for having logic to wait until the server is actually up and running before continuing with the test.

The issue was that unless you explicitly provided a server_id to get_server the server_id in state._threads would not match the server_id on state._servers, meaning that when it came time to shut down the threads/servers the recent changes I made to the clean up logic would never find the thread to shut down.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.14%. Comparing base (5578f98) to head (75975b6).
Report is 1182 commits behind head on main.

Files Patch % Lines
panel/io/server.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6492      +/-   ##
==========================================
- Coverage   82.75%   82.14%   -0.61%     
==========================================
  Files         239      314      +75     
  Lines       34507    46313   +11806     
==========================================
+ Hits        28555    38046    +9491     
- Misses       5952     8267    +2315     
Flag Coverage Δ
ui-tests 36.69% <88.00%> (-1.43%) ⬇️
unitexamples-tests 71.49% <96.00%> (-2.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit d071207 into main Mar 14, 2024
12 of 15 checks passed
@philippjfr philippjfr deleted the tests_cleanup branch March 14, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant