Feature: volume detection #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pvizeli @bdraco what would need to happen to have this work merged? this would be a great addition to https://www.home-assistant.io/integrations/ffmpeg_noise/ |
|
I have been looking for volume detection since my son birth, almost 2y, I love your PR @daniel-simpson |
|
This modification is very useful, is it possible to convert it into a custom component? |
pvizeli
approved these changes
Aug 13, 2024
|
Can you rebase? |
daniel-simpson
force-pushed
the
feature/volume-detection
branch
from
69693d0
to
232b5c0
Compare
|
@pvizeli rebased as requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code for max and mean volume sensors using ffmpeg's volumedetection argument, as per feature request #74.
There doesn't seem to be any tests in this project (other than linting?), so this is more a proof of concept for now. Very happy to get some feedback if this would be useful, or if I've missed anything.
Thanks!