A few small optimizations #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
added
the
maintenance
frenck
approved these changes
Jul 25, 2023
marcelveldt
added
maintenance
| @@ -409,7 +403,7 @@ async def read_attribute( | |||
| ) | |||
| ) | |||
| read_atributes = self._parse_attributes_from_read_result(result.attributes) | |||
| return read_atributes[attribute_path] | |||
| return read_atributes.get(attribute_path, None) | |||
There was a problem hiding this comment.
None is the default value returned when the key is missing in the dict.
| node_lock = self._get_node_lock(node_id) | ||
| if self.chip_controller is None: | ||
| raise RuntimeError("Device Controller not initialized.") | ||
| try: | ||
| # the sdk crashes when multiple resolves happen at the same time | ||
| # guard simultane resolves with a lock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small speedups and code cleanup