Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust subscription logic a bit #416

Merged
merged 12 commits into from
Oct 25, 2023
Merged

Adjust subscription logic a bit #416

merged 12 commits into from
Oct 25, 2023

Conversation

marcelveldt
Copy link
Contributor

Adjust our subscription logic a bit based on the recent discussions around this topic within CSA where a too low subscription ceiling hurts (thread) networks and battery life.

  • Adjusted our report interval ceiling to a random interval between 500 and 700 seconds, so more or less 10 minutes
  • Removed the manual resolve workaround as it was too noisy, let's wait for the real solution where operational nodes are rediscovered
  • Updated comments to explain the situation
  • Switch to wildcard subscriptions as soon as the amount of watched attributes is above 9

@marcelveldt marcelveldt added the maintenance Code (quality) improvement or small enhancement which not a new feature label Oct 25, 2023
matter_server/server/device_controller.py Outdated Show resolved Hide resolved
matter_server/server/device_controller.py Outdated Show resolved Hide resolved
matter_server/server/device_controller.py Outdated Show resolved Hide resolved
matter_server/server/device_controller.py Outdated Show resolved Hide resolved
matter_server/server/device_controller.py Outdated Show resolved Hide resolved
matter_server/server/device_controller.py Outdated Show resolved Hide resolved
matter_server/server/device_controller.py Outdated Show resolved Hide resolved
matter_server/server/device_controller.py Outdated Show resolved Hide resolved
@MartinHjelmare MartinHjelmare merged commit d0cb830 into main Oct 25, 2023
4 checks passed
@MartinHjelmare MartinHjelmare deleted the subscriptions-fix branch October 25, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code (quality) improvement or small enhancement which not a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants