-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to commission with code on network only #470
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agners
force-pushed
the
commission-with-code-network-only
branch
from
December 21, 2023 14:59
e50321d
to
b95bf2e
Compare
Add a parameter which instructs the SDK to search for the device only on the network. This is useful when using the manual pairing code, which does not contain a device specific discovery capabilties. This is useful to prevent the SDK from searching via Bluetooth from the Android App (which provides a manual pairing code when using the non-App integrated Matter onboarding flow).
agners
force-pushed
the
commission-with-code-network-only
branch
from
December 21, 2023 15:01
b95bf2e
to
e8be55a
Compare
marcelveldt
reviewed
Dec 21, 2023
marcelveldt
reviewed
Dec 21, 2023
marcelveldt
reviewed
Dec 21, 2023
MartinHjelmare
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a parameter which instructs the SDK to search for the device only on the network. This is useful when using the manual pairing code, which does not contain a device specific discovery capabilties.
This is useful to prevent the SDK from searching via Bluetooth from the Android App (which provides a manual pairing code when using the non-App integrated Matter onboarding flow).