Guard node resolving with a lock #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
requested review from
MartinHjelmare
and removed request for
MartinHjelmare
marcelveldt
added
bugfix
MartinHjelmare
approved these changes
Jan 29, 2024
Co-authored-by: Martin Hjelmare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's still not entirely clear but it looks like multiple resolves at the same time is not very safe and one action may even be discarded if another attempt comes in. So for example if the server is busy trying to resolve an offline node it may cause commissioning to fail. So for safety reasons put a lock on the resolving. It makes init of nodes somewhat slower but its safer.