Some small tweaks to the subscripions logic #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
added
the
maintenance
|
CI is failing but that is a global issue (signing issue on the ubuntu used for CI) |
MartinHjelmare
approved these changes
Apr 24, 2024
Co-authored-by: Martin Hjelmare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we're still hunting down the cause for the continuous "subscription failed with Error: 50, re-subscribing in 0 ms" errors where the subscription of a node suddenly gets lost with no reason, I found a few tweaks. Not really solutions to the issue but still good to apply.
Increase subscription ceiling for WiFi devices to 60 seconds (same as mains powered thread devices) as we see the error mostly for WiFi devices.
Remove keepSubscriptions on the subscription itself as its kind of redundant with the autoResubscribe and saves a bit of stress on the device itself (hopefully) - though this is still very unclear.
Remove fabricFiltered=False (so reinstate it being set to True) on the subscription itself as the only reason we were doing that is to have an up to date list of fabrics at all times. Removing it in the sub saves a little bit of stress on the device.
Refresh the node's fabrics in the diagnostics itself to ensure we have the latest info as an alternative for having the fabricFiltered=False in the sub.