Use secrets to generate the discriminator #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the secrets module which is cryptographically secure to generate the discriminator. The discriminator probably doesn't need to be cryptographically safe, but it also doesn't hurt and gets rid of a QA exception.
|
I am using the secrets module also in #709, where I need to generate a passcode. The passcode should be cryptographically safe, so I think it is better to use the same module everywhere. |
agners
added
the
maintenance
balloob
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the secrets module which is cryptographically secure to generate the discriminator. The discriminator probably doesn't need to be cryptographically safe, but it also doesn't hurt and gets rid of a QA exception.