Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to asyncio Matter SDK API #765

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Convert to asyncio Matter SDK API #765

merged 4 commits into from
Jun 20, 2024

Conversation

agners
Copy link
Collaborator

@agners agners commented Jun 18, 2024

Changes required to use the new co-routines based Matter SDK API.

@agners agners marked this pull request as draft June 18, 2024 16:41
Changes required to use the new co-routines based Matter SDK API.
More often than not commissioning retries are not needed. In fact
they lead to worse UX performance as it takes longer for an attempt
which is bound to fail (e.g. because the code is wrong or the device
is not actually commissionable) to fail.
@agners agners added the maintenance Code (quality) improvement or small enhancement which not a new feature label Jun 20, 2024
@agners agners changed the title WIP: Convert to asyncio Matter SDK API Convert to asyncio Matter SDK API Jun 20, 2024
@agners agners requested a review from marcelveldt June 20, 2024 17:29
@agners agners marked this pull request as ready for review June 20, 2024 17:29
Copy link
Contributor

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @agners !

@marcelveldt marcelveldt merged commit ab4dc0f into main Jun 20, 2024
4 checks passed
@marcelveldt marcelveldt deleted the convert-to-asyncio-api branch June 20, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code (quality) improvement or small enhancement which not a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants