Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom cluster definition for ThirdReality Energy reporting #789

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

marcelveldt
Copy link
Contributor

@marcelveldt marcelveldt commented Jul 3, 2024

ThirdReality Private Metering cluster server.pdf

I only implemented the energy and power metering attributes

matter_server/common/custom_clusters.py Outdated Show resolved Hide resolved
@marcelveldt marcelveldt added the maintenance Code (quality) improvement or small enhancement which not a new feature label Jul 3, 2024
@marcelveldt marcelveldt requested a review from agners July 3, 2024 13:33
@marcelveldt marcelveldt merged commit 8d404ab into main Jul 3, 2024
4 of 5 checks passed
@marcelveldt marcelveldt deleted the thirdreality-cluster branch July 3, 2024 13:39
class CurrentSummationDelivered(
ClusterAttributeDescriptor, CustomClusterAttributeMixin
):
"""CurrentSummationDelivered represents the most recent summed value of Energy consumed in the premise.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to stay within 72 characters per line for docstrings in accordance with PEP8.

We don't need to repeat the class name in the docstring. That will help shorten it. Write eg:

Represent the latest sum of energy consumed on the premise.

CurrentSummationDelivered is updated continuously as new measurements are made.
This attribute is Read only.
Value is set to zero when leave command is received (beginning version 2.6.15),
or local factory reset(10s) is performed on the device..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double period

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code (quality) improvement or small enhancement which not a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants