Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A small optimization to the node setup #798

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

marcelveldt
Copy link
Contributor

If you have issues in your Thread network and/or multiple misbehaving devices we get trapped into a deadlock situation if we have 5 nodes stuck in setup. In that case no devices will be setup at all.

This changes the logic a tiny bit so we still use a semaphore to somewhat throttle the burst of traffic that the setup generates on the thread network but back out of it in case a node hangs in there.

  • Use set-up semaphore only for Thread devices
  • Release semaphore when we detect a node hangs in setup

@marcelveldt marcelveldt merged commit 0b85b49 into main Jul 11, 2024
3 checks passed
@marcelveldt marcelveldt deleted the setup-node-optimize branch July 11, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants