Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct bluetooth commissioning support #799

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

marcelveldt
Copy link
Contributor

Add (explicit) support for commissioning using Bluetooth next to on-network commissioning.
Because it can be very unstable for some bluetooth adapters (like the pi builtin adapter for example), it requires a specific bluetooth adapter id/index

@marcelveldt marcelveldt marked this pull request as draft July 11, 2024 13:30
@marcelveldt marcelveldt added the new-feature New feature or request label Jul 11, 2024
Copy link
Collaborator

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have a user friendly way to select the Bluetooth adapter in the add-on config. Did you intend to just have a text field with a number there? 🤔

Essentially putting 0 there will be equivalent to what is happening today (None is just setting the adapter id to 0 in the Python Matter SDK code).

matter_server/server/stack.py Show resolved Hide resolved
@marcelveldt
Copy link
Contributor Author

I don't think we have a user friendly way to select the Bluetooth adapter in the add-on config. Did you intend to just have a text field with a number there? 🤔

Maybe we should go with a boolean value to enable it and then an index number ?
Not sure if add-on config schema allows a nullable int ?

@agners
Copy link
Collaborator

agners commented Jul 11, 2024

Not sure if add-on config schema allows a nullable int ?

Optional config's are supported, which I think would work well here. If the config is set, we add the command line argument (and hence "enable" Bluetooth support).

@marcelveldt marcelveldt marked this pull request as ready for review July 11, 2024 14:56
@agners agners merged commit fa4002e into main Jul 11, 2024
4 of 5 checks passed
@agners agners deleted the direct-bluetooth-support branch July 11, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants