Enable server interactions by default #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables server cluster interactions on a controller. But currently more importantly, it enables advertisement of active controller operational identities, or in other words, it makes sure that the controller publishes a mDNS/DNS-SD operational discovery service. This is required for persistent subscriptions to work: Matter devices which support persistent subscriptions (e.g. Nanoleaf bulbs) will try to reestablish the subscriptions right after startup. For that to work they need to resolve the controller through operational discovery. In other words, with this change nodes come much quicker available/ controllable when they restart.
marcelveldt
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables server cluster interactions on a controller. But currently more importantly, it enables advertisement of active controller operational identities, or in other words, it makes sure that the controller publishes a mDNS/DNS-SD operational discovery service.
This is required for persistent subscriptions to work: Matter devices which support persistent subscriptions (e.g. Nanoleaf bulbs) will try to reestablish the subscriptions right after startup. For that to work they need to resolve the controller through operational discovery.
In other words, with this change nodes come much quicker available/controllable when they restart.