Add note about Docker default command #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our Dockerfile uses the CMD instruction to run the server with sensible default arguments. Often folks forget to add those when customizing their command. This adds a note to the README.md and the compose.yml file to remind them. This also removes the D-Bus access in the default startup example since D-Bus is only required for Bluetooth support (which is no longer enabled by default). An additional example with the correct command line and D-Bus access should make it clear what needs to be done to restore previous behavior.
marcelveldt
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Dockerfile uses the CMD instruction to run the server with sensible default arguments. Often folks forget to add those when customizing their command. This adds a note to the README.md and the compose.yml file to remind them.
This also removes the D-Bus access in the default startup example since D-Bus is only required for Bluetooth support (which is no longer enabled by default). An additional example with the correct command line and D-Bus access should make it clear what needs to be done to restore previous behavior.