Add fabric label on commissioning #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a fabric label right after commissioning. This will make it easier for other platforms to identify what particular fabrics a device is commissioned with.
|
The hard coded value is probably not a good idea. I was thinking the Home Assistant instance name would be a good candidate to use here. We could either pass the string once on startup (set an instance name right after connect), or extend the commission command... 🤔 |
marcelveldt
reviewed
Sep 27, 2024
MartinHjelmare
requested changes
Sep 29, 2024
MartinHjelmare
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fabric label right after commissioning. This will make it easier for other platforms to identify what particular fabrics a device is commissioned with.