Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add images for fyta #5210

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Add images for fyta #5210

merged 6 commits into from
Mar 18, 2024

Conversation

dontinelli
Copy link
Contributor

@dontinelli dontinelli commented Feb 12, 2024 •
edited
Loading

Proposed change

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

This was referenced Feb 17, 2024
Closed
Merged
@frenck frenck added the has-parent This PR has a parent PR in a other repo label Feb 19, 2024
@klaasnicolaas
Copy link
Member

klaasnicolaas commented Mar 1, 2024 •
edited
Loading

Since you want to add the integration to core, I see no reason to add the assets to the custom_integrations folder (see also CI error).

./Klaas

@dontinelli
Copy link
Contributor Author

Since you want to add the integration to core, I see no reason to add the assets to the custom_integrations folder (see also CI error).

./Klaas

Thank you. Was not aware that the core images can also be uses for custom components. I removed the duplicate.

@klaasnicolaas
Copy link
Member

What matters is that an integration domain is unique and that determines which brand assets are displayed. Since you are adding the integration to core, it is most logical to also add the assets only to core.

./Klaas

@dontinelli
Copy link
Contributor Author

What matters is that an integration domain is unique and that determines which brand assets are displayed. Since you are adding the integration to core, it is most logical to also add the assets only to core.

./Klaas

@klaasnicolaas : as the integration PR now has been merged into dev, may I ask you to review? Thanks!

c0ffeeca7
c0ffeeca7 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @dontinelli 👍

@c0ffeeca7 c0ffeeca7 merged commit 90533c5 into home-assistant:master Mar 18, 2024
5 checks passed
Athozs pushed a commit to Athozs/brands that referenced this pull request Aug 30, 2024
@dontinelli @Athozs
Add images for fyta (home-assistant#5210)
57ace4c 
* Add images for fyta

* add files for fyta custom_component

* remove cc duplicate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0ffeeca7 c0ffeeca7 c0ffeeca7 approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dontinelli @klaasnicolaas @c0ffeeca7 @frenck