Freebox: Unable to enumerate raid disks WARN appears more than 10000 times since 2023.8.1

[Quentame]

The problem

#95242 added RAID info to disks attached to Freebox routers, but fail the integration to start for people without disks or RAID, its fix #97696 added try-catch with a warn, but in the update function. It should be at init, then use a boolean or other to not warn more.

Actual behavior: WARN log infinitaly, at every update
Expected behavior: WARN log only once, at initialisation

What version of Home Assistant Core has the issue?

core-2023.8.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

freebox

Link to integration documentation on our website

https://www.home-assistant.io/integrations/freebox/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant.components.freebox.router
Source: components/freebox/router.py:86
Integration: Freebox (documentation, issues)
First occurred: 7 août 2023 à 19:04:31 (11528 occurrences)
Last logged: 19:09:13

Unable to enumerate raid disks

Additional information

No response

[home-assistant]

Hey there @hacf-fr, mind taking a look at this issue as it has been labeled with an integration (freebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of freebox can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Renames the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign freebox Removes the current integration label and assignees on the issue, add the integration domain after the command.

_{^{(message by CodeOwnersMention)}}

---

freebox documentation
freebox source
_{^{(message by IssueLinks)}}

[Quentame]

Hi same issue on HAOS 10.4 and 2023.8.2 core.

Use 👍 on the issue to note you are having the same issue, not adding additional infos to the original issue marks your comments as spam.

The issue has not been solved yet, so it's normal it's still on next versions.

[fthiery]

Hi, really sorry for this regression, it was not possible for me to simulate a different freebox model, and nothing indicated that the freebox API is not the same :(

I have opened a PR here: #98740

I'm not sure whether we should try to mock the error for simulated different router models...

Since i only own a Delta model, can anyone with e.g. a Freebox Revolution try my PR ? As a reminder, to test it, you need to upload the homeasistant/components/freebox folder into your custom_components folder, without forgetting to add a version key into the manifest file (see https://developers.home-assistant.io/docs/development_tips#test-core-integration-changes-in-your-production-home-assistant-environment)

[Quentame]

Hi, really sorry for this regression, it was not possible for me to simulate a different freebox model, and nothing indicated that the freebox API is not the same :(

I have opened a PR here: #98740

I'm not sure whether we should try to mock the error for simulated different router models...

Since i only own a Delta model, can anyone with e.g. a Freebox Revolution try my PR ? As a reminder, to test it, you need to upload the homeasistant/components/freebox folder into your custom_components folder, without forgetting to add a version key into the manifest file (see https://developers.home-assistant.io/docs/development_tips#test-core-integration-changes-in-your-production-home-assistant-environment)

Hi @fthiery !

No worries, I know those kind of things can happen with different hardware having specificities and acting differently.

I have a Freebox Revolution, will test on dev if I find time, otherwise 2023.8.4

Thanks !

---

EDIT: working well, displaying the error message only once.