Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support device as predefined slot list #101245

Closed
wants to merge 6 commits into from

Conversation

tetele
Copy link
Contributor

@tetele tetele commented Oct 2, 2023

Breaking change

NO

Proposed change

Add {device} as a pre-filled slot for intent recognition, populated with device names in order to allow queries concerning entities that belongs to a named device.

Here is a couple of custom sentences that could work with this feature:

language: "en"
intents:
  HassGetState:
    data:
      - sentences:
        - "what is the {device_class} of {device}"
        slots:
          domain: "sensor"
      - sentences:
        - "what is the {domain} of {device}"

lists:
  device_class:
    values:
      - "temperature"
      - "battery"
  domain:
    values:
      - in: "home state"
        out: "device_tracker"

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Oct 2, 2023

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration (intent) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of intent can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign intent Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

home-assistant bot commented Oct 2, 2023

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of conversation can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign conversation Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@tetele
Copy link
Contributor Author

tetele commented Oct 2, 2023

Leaving the code coverage for a bit. Will fix if the rest of the PR is ok.

@tetele tetele marked this pull request as ready for review October 2, 2023 14:26
@tetele tetele requested review from synesthesiam and a team as code owners October 2, 2023 14:26
Copy link

github-actions bot commented Mar 4, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Mar 4, 2024
@tetele
Copy link
Contributor Author

tetele commented Mar 7, 2024

Not yet stale

@github-actions github-actions bot removed the stale label Mar 7, 2024
@tetele
Copy link
Contributor Author

tetele commented Mar 11, 2024

Breaking up into smaller PRs

@tetele tetele mentioned this pull request Mar 11, 2024
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants