-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use home/sleep preset in ViCare climate entity #105636
Conversation
PRESET_HOME: VICARE_PROGRAM_NORMAL, | ||
PRESET_SLEEP: VICARE_PROGRAM_REDUCED, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This results in having the presets selectable via select or button. But actually these presets are determined via the internal heating schedule. So they cannot be activated. When selecting the "home" during night time, there will be no error, but the preset will fallback to "reduced".
Is this behavior acceptable? I would like to see which preset is active (like seen on the device page).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened a feature discussion on that topic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Euh I don't really see what problem you are pointing at, could you maybe elaborate a bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viessmann heatings are always running on a schedule, normal (day) and reduced (night) that the user can define on its own.
These are presets that are determined by the schedule only, one cannot activate/deactivate them. One can only overrule it with the other presets like eco, comfort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there are some presets that can be used and some that can not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I think it's valuable to see which one is active and not just display none. Therefore the feature request to display it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so what will we do in this PR? Add the presets so they will show?
What if we set it to a preset you can't select?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also be fine with removing this change and just go with the changes from line 88, so I can see the preset on the entity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we set it to a preset you can't select?
Integration will ignore reduced and normal. So when you select normal during night time it will just do nothing and flip back to reduced.
Breaking change
Proposed change
This makes the default ViCare programs normal/reduced (Nachtabsenkung) map to the HA presets home and sleep.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: