-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conversation_id parameter to conversation.process service #106078
Conversation
Hey there @home-assistant/core, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
b9e97bc
to
c8faf71
Compare
Thanks! |
* upstream/dev: (2071 commits) Set zwave_js voltage sensor suggested precision (home-assistant#107116) Bump bluetooth-adapters to 0.17.0 (home-assistant#107195) Disable IPv6 in the opower integration to fix AEP utilities (home-assistant#107203) Fix conversation snapshots (home-assistant#107196) Report missing entities/areas instead of failing to match in Assist (home-assistant#107151) Bump to PyTado 0.17.3 (home-assistant#107181) Fix switch states in AVM FRITZ!Box Tools (home-assistant#107183) Fix tplink overloading power strips (home-assistant#104208) Update sensorpush-ble library to 1.6.1 (home-assistant#107168) Bump aiohomekit to 3.1.2 (home-assistant#107177) Introduce base entity in streamlabs water (home-assistant#107095) Clean up outdated entity replacement logic in Guardian (home-assistant#107160) Add conversation_id parameter to conversation.process service (home-assistant#106078) Pass aiohttp clientsession to tedee integration (home-assistant#107089) Update Home Assistant base image to 2024.01.0 - Python 3.12 (home-assistant#107175) Remove precision in streamlabs water (home-assistant#107096) Pass down language to hassil (home-assistant#106490) Use snapshots in Glances sensor tests (home-assistant#107159) Cache homekit_controller supported features (home-assistant#106702) Migrate AVM FRITZ!Box Call monitor to has entity name (home-assistant#99752) ...
@@ -883,6 +884,8 @@ async def test_turn_on_intent( | |||
data = {conversation.ATTR_TEXT: sentence} | |||
if agent_id is not None: | |||
data[conversation.ATTR_AGENT_ID] = agent_id | |||
if conversation_id is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of adding this check, we can refactor the parameter to be a dict that we always use to update the service data. The two cases would be a dict with the conversation id and an empty dict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be something like this then for data
?
{
"conversation_id": { "value": "..." }
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this:
pytest.mark.parametrize("conversation_data", [{"conversation_id": "my_new_conversation"} , {}])
We can replace agent_id
similarly.
Proposed change
Add conversation_id parameter to conversation.process service.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: