-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZHA ZCL thermostat entities #106563
Add ZHA ZCL thermostat entities #106563
Conversation
…ermostat.pi_heating_demand and thermostat_ui.keypad_lockout
… because of use of bitmap8 instead of enum8
…rting and read config for danfoss and keypad_lockout.
Ready for merge again. |
Ready for merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to look pretty good.
Maybe also change the capitalization(s) in some of the added docstrings (and add a dot at the end, although this doesn't seem to be a requirement anymore).
Thanks, just fixed up the docstrings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to look good now!
Ready for merge again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still good! Thanks again.
Proposed change
Add ZCL Thermostat UI entity: Keypad Lockout
Add ZCL Thermostat entities: min_heat_setpoint_limit, max_heat_setpoint_limit, pi_heating_demand, setpoint_change_source
Most of these are mandatory ZCL attributes, so it is reasonable to expect devices to implement them.
Type of change
Additional information
This is closely related to the Danfoss PR: #86907
This is however not specific to Danfoss, which makes it logical to make a separate PR. This will also make it easier to review.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: