Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZHA ZCL thermostat entities #106563

Merged
merged 138 commits into from
Jan 31, 2024

Conversation

Caius-Bonus
Copy link
Contributor

@Caius-Bonus Caius-Bonus commented Dec 28, 2023

Proposed change

Add ZCL Thermostat UI entity: Keypad Lockout
Add ZCL Thermostat entities: min_heat_setpoint_limit, max_heat_setpoint_limit, pi_heating_demand, setpoint_change_source

Most of these are mandatory ZCL attributes, so it is reasonable to expect devices to implement them.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

This is closely related to the Danfoss PR: #86907

This is however not specific to Danfoss, which makes it logical to make a separate PR. This will also make it easier to review.

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

…ermostat.pi_heating_demand and thermostat_ui.keypad_lockout
…rting and read config for danfoss and keypad_lockout.
@Caius-Bonus
Copy link
Contributor Author

Ready for merge again.

@Caius-Bonus
Copy link
Contributor Author

Ready for merge

Copy link
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to look pretty good.

Maybe also change the capitalization(s) in some of the added docstrings (and add a dot at the end, although this doesn't seem to be a requirement anymore).

tests/components/zha/test_sensor.py Outdated Show resolved Hide resolved
tests/components/zha/test_sensor.py Outdated Show resolved Hide resolved
@Caius-Bonus
Copy link
Contributor Author

Thanks, just fixed up the docstrings

Copy link
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to look good now!

@Caius-Bonus
Copy link
Contributor Author

Ready for merge again.

Copy link
Member

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good! Thanks again.

@TheJulianJES TheJulianJES merged commit a7a41e5 into home-assistant:dev Jan 31, 2024
23 checks passed
@Caius-Bonus Caius-Bonus deleted the AddZCLThermostatEntities branch January 31, 2024 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants