Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doors and charge cable binary sensors to Tessie #107172

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

Bre77
Copy link
Contributor

@Bre77 Bre77 commented Jan 4, 2024

Breaking change

Proposed change

Add doors and charge cable binary sensors

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Bre77 Bre77 changed the title Add door binary sensors to Tessie Add doors and charge cable binary sensors to Tessie Jan 4, 2024
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@jpbede jpbede merged commit b711c49 into home-assistant:dev Jan 29, 2024
23 checks passed
@Bre77 Bre77 deleted the tessie-doors branch January 29, 2024 21:00
Moustachauve pushed a commit to Moustachauve/HA-core that referenced this pull request Jan 30, 2024
…07172)

* Add doors

* Update homeassistant/components/tessie/strings.json

Co-authored-by: Joost Lekkerkerker <[email protected]>

* Add charge cable

---------

Co-authored-by: Joost Lekkerkerker <[email protected]>
This was referenced Jan 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tessie: Door status attributes missing
4 participants