Fix Tado unique mobile device dispatcher #107631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @michaelarnauts, @chiefdragon, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
erwindouna
changed the title
MartinHjelmare
requested changes
Jan 9, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
MartinHjelmare
requested changes
Jan 9, 2024
Co-authored-by: Martin Hjelmare <[email protected]>
Co-authored-by: Martin Hjelmare <[email protected]>
|
@MartinHjelmare It can be merged now. :) |
MartinHjelmare
changed the title
catsmanac
pushed a commit
to catsmanac/ha-core-dev
that referenced
this pull request
Jan 10, 2024
* Add unique home ID device dispatch * Adding fixture for new setup * Minor refactor work * Add check for unlinked to different homes * If the interface returns an error * Proper error handling * Feedback fixes * Comments for error in client * Typo * Update homeassistant/components/tado/__init__.py Co-authored-by: Martin Hjelmare <[email protected]> * Update homeassistant/components/tado/__init__.py Co-authored-by: Martin Hjelmare <[email protected]> * Update devices fix standard * Dispatch out of loop * Update dispatcher * Clean up --------- Co-authored-by: Martin Hjelmare <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add a unique dispatcher per mobile device, instead of running it on the generic dispatcher. This caused issues when users have multiple homes and multiple installations running on one HA installation.
Having an unique dispatcher per mobile device, based on the underlying home ID, will prevent a too generic dispatcher for all mobile devices. The generic dispatcher would load only the mobile devices known per home, and missed the mobile devices linked to a different entry.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: