Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioswitcher to 3.4.1 #107730

Merged
merged 11 commits into from
Jan 10, 2024

Conversation

YogevBokobza
Copy link
Contributor

@YogevBokobza YogevBokobza commented Jan 10, 2024

Bump aioswitcher to 3.4.1

GitHub diff: TomerFi/aioswitcher@3.3.0...3.4.1
Release notes: https://github.com/TomerFi/aioswitcher/releases/tag/3.4.1

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @thecode, mind taking a look at this pull request as it has been labeled with an integration (switcher_kis) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switcher_kis can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switcher_kis Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@YogevBokobza YogevBokobza changed the title switcher: added support for device_key logic included in aioswitcher=… switcher: added support for device_key logic Jan 10, 2024
Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the following:

@home-assistant home-assistant bot marked this pull request as draft January 10, 2024 15:08
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@YogevBokobza YogevBokobza marked this pull request as ready for review January 10, 2024 15:08
@thecode
Copy link
Member

thecode commented Jan 10, 2024

You need to update the mocked devices at:
https://github.com/home-assistant/core/blob/dev/tests/components/switcher_kis/consts.py
to include the device_key

@YogevBokobza
Copy link
Contributor Author

You need to update the mocked devices at: https://github.com/home-assistant/core/blob/dev/tests/components/switcher_kis/consts.py to include the device_key

I updated the file you mentioned. Do need an update in test_X files on the same path?

@YogevBokobza YogevBokobza changed the title switcher: added support for device_key logic Bump aioswitcher to 3.4.1 Jan 10, 2024
@YogevBokobza
Copy link
Contributor Author

@thecode Any idea why the only 2 tests failed? I cant understand why from the log..

Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YogevBokobza 👍

@thecode thecode added this to the 2024.1.3 milestone Jan 10, 2024
@thecode
Copy link
Member

thecode commented Jan 10, 2024

Tips for next PRs:

  • You can include list of devices you tested the changes on so others can know which devices needs testing (I tested this PR before approving on Switcher Touch and Switcher Plug)
  • Please check if there are open bugs related to the bugfix (I edited your PR comment and linked to the relevant bug)
  • You can ask to add a PR to the next milestone (for this PR it will be 2024.1.3), only bugfixes are accepted, PRs which include new functionality needs to go to dev first and wait for next major release.
  • I suggest again to install Development Environment in the dev container you have built in task to run tests & coverage (which will take ~30seconds instead of here you have to wait 45minutes) and it has all the linting & check tools used by the CI that runs when you commit changes locally.

Thanks for finding & fixing this issue.

@thecode thecode merged commit bdba6f4 into home-assistant:dev Jan 10, 2024
49 checks passed
@YogevBokobza
Copy link
Contributor Author

  • You can ask to add a PR to the next milestone (for this PR it will be 2024.1.3), only bugfixes are accepted, PRs which include new functionality needs to go to dev first and wait for next major release.

Thanks for the tips!

You can ask to add a PR to the next milestone (for this PR it will be 2024.1.3), only bugfixes are accepted, PRs which include new functionality needs to go to dev first and wait for next major release.

How to do that ?

@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch not working
3 participants