-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump aioswitcher to 3.4.1 #107730
Bump aioswitcher to 3.4.1 #107730
Conversation
Hey there @thecode, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the following:
- Failing CI tests (I highly recommend setting up Development Environment and run there the tests and pre-commit.
- PR description example for a dependency bump: Bump aioswitcher to 3.1.0 #80534, review which checks apply and mark them in the checklist
- PR example for a bugfix: Bump aioswitcher to 3.3.0 #91215 which also apply in this case since this is a bugfix
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
You need to update the mocked devices at: |
I updated the file you mentioned. Do need an update in test_X files on the same path? |
@thecode Any idea why the only 2 tests failed? I cant understand why from the log.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @YogevBokobza 👍
Tips for next PRs:
Thanks for finding & fixing this issue. |
Thanks for the tips!
How to do that ? |
Bump aioswitcher to 3.4.1
GitHub diff: TomerFi/aioswitcher@3.3.0...3.4.1
Release notes: https://github.com/TomerFi/aioswitcher/releases/tag/3.4.1
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: