-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readable state for tesla wall connector #107909
Conversation
Hey there @einarhauks, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Should we mark this as a breaking change as someone may already be using the old sensor in their automations? Or has the sensor not yet been released? |
The entity ID of the old sensor will not change because it's already created. And it will be only disabled for new integration setups. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
fa7b779
to
9028164
Compare
Co-authored-by: Franck Nijhof <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @piitaya 👍
../Frenck
Proposed change
Adds new state sensor with translated state. The old state sensor which contained the raw data (a number) has been renamed to
status_code
and disabled by default.I looked at tesla wall connector third party app for state mapping (https://apps.apple.com/us/app/wall-monitor-for-tesla/id1635414689) and tested with my device.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: