Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readable state for tesla wall connector #107909

Merged
merged 8 commits into from
Jan 31, 2024
Merged

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jan 12, 2024

Proposed change

Adds new state sensor with translated state. The old state sensor which contained the raw data (a number) has been renamed to status_code and disabled by default.

I looked at tesla wall connector third party app for state mapping (https://apps.apple.com/us/app/wall-monitor-for-tesla/id1635414689) and tested with my device.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @einarhauks, mind taking a look at this pull request as it has been labeled with an integration (tesla_wall_connector) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tesla_wall_connector can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tesla_wall_connector Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@jpbede
Copy link
Member

jpbede commented Jan 13, 2024

Should we mark this as a breaking change as someone may already be using the old sensor in their automations? Or has the sensor not yet been released?

@piitaya
Copy link
Member Author

piitaya commented Jan 13, 2024

The entity ID of the old sensor will not change because it's already created. And it will be only disabled for new integration setups.

Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

@home-assistant home-assistant bot marked this pull request as draft January 14, 2024 10:23
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@piitaya piitaya marked this pull request as ready for review January 14, 2024 12:55
@home-assistant home-assistant bot requested a review from frenck January 14, 2024 12:55
@piitaya piitaya marked this pull request as draft January 14, 2024 15:50
@piitaya piitaya marked this pull request as ready for review January 14, 2024 19:02
@piitaya piitaya mentioned this pull request Jan 31, 2024
20 tasks
@piitaya piitaya marked this pull request as draft January 31, 2024 14:01
@piitaya piitaya marked this pull request as ready for review January 31, 2024 14:01
@piitaya piitaya requested a review from jpbede January 31, 2024 15:07
@home-assistant home-assistant bot marked this pull request as draft January 31, 2024 15:33
@piitaya piitaya marked this pull request as ready for review January 31, 2024 15:33
@home-assistant home-assistant bot requested a review from frenck January 31, 2024 15:33
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @piitaya 👍

../Frenck

@piitaya piitaya merged commit c8bfb28 into dev Jan 31, 2024
23 checks passed
@piitaya piitaya deleted the tesla_wall_connector_state branch January 31, 2024 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants