Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state_class to Kostal plenticore sensors #108096

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

stegm
Copy link
Contributor

@stegm stegm commented Jan 15, 2024

Proposed change

Some sensors were missing the state_class and therefore could not be used in the statistics graph. One sensor had the wrong class (MEASUREMENT instead of TOTAL_INCREASING).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Add state_class to sensors. Add state_class to Kostal plenticore sensors Jan 15, 2024
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am stopping reviewing as I need more information on the statistics sensors. On all of them and not only the one I commented on

homeassistant/components/kostal_plenticore/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 17, 2024 09:26
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@stegm stegm marked this pull request as ready for review January 23, 2024 17:46
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stegm 👍

@edenhaus edenhaus merged commit 7fe4a34 into home-assistant:dev Jan 31, 2024
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
@stegm stegm deleted the fix_state_class branch February 19, 2024 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants