Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract foscam base entity for reuse #108893

Merged
merged 5 commits into from
Jan 29, 2024
Merged

Conversation

krmarien
Copy link
Contributor

Breaking change

Proposed change

Extra base FoscamEntity from camera to reuse it in to be added other platforms.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @skgsergio, mind taking a look at this pull request as it has been labeled with an integration (foscam) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of foscam can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign foscam Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

homeassistant/components/foscam/entity.py Outdated Show resolved Hide resolved
homeassistant/components/foscam/entity.py Outdated Show resolved Hide resolved
homeassistant/components/foscam/entity.py Outdated Show resolved Hide resolved
homeassistant/components/foscam/entity.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 26, 2024 06:38
@krmarien krmarien marked this pull request as ready for review January 27, 2024 05:00
@home-assistant home-assistant bot marked this pull request as draft January 27, 2024 08:06
@krmarien krmarien marked this pull request as ready for review January 29, 2024 19:29
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing, we can make use of the const's here

homeassistant/components/foscam/entity.py Show resolved Hide resolved
homeassistant/components/foscam/entity.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 29, 2024 20:42
@krmarien krmarien marked this pull request as ready for review January 29, 2024 20:50
@jpbede jpbede merged commit 0013f18 into home-assistant:dev Jan 29, 2024
23 checks passed
Moustachauve pushed a commit to Moustachauve/HA-core that referenced this pull request Jan 30, 2024
* Extract foscam base entity for reuse

* Cleanup

* More cleanup

* Cleanup constructor

* Use more constants
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants