-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tankerkoenig to new aiotankerkoenig package #108913
Conversation
Hey there @guillempages, @mib1185, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jpbede
Good job, i've tested the code and it works well 👍
Please add a reference to the new library to the initial post and i've some further comments
Thanks @mib1185 for testing and your review 👍. |
failed tests are unrelated
|
self._data: dict[str, Any] = {} | ||
self._stations: dict[str, str] = {} | ||
_data: dict[str, Any] = {} | ||
_stations: dict[str, str] = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't initialize class attributes to mutable objects unless explicitly required. It's very error prone. Use an init method to set instance attributes.
Proposed change
Replace the existing sync package (pytankerkoenig) for tankerkoenig, which has not received any updates in the last 3 years, with a new async package.
In addition, some things have been cleaned up and the logging of data removed, as we already have the diagnostics with the data.
Link to the new async package: https://github.com/jpbede/aiotankerkoenig
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: