Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp to 3.9.3 #109025

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Bump aiohttp to 3.9.3 #109025

merged 4 commits into from
Jan 29, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 28, 2024

needs https://github.com/aio-libs/aiohttp/actions/runs/7701265001

Proposed change

https://github.com/aio-libs/aiohttp/releases/tag/v3.9.3

resolves GHSA-5h86-8mv2-jq9f
resolves GHSA-8qpw-xqxj-h4r2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2024.1.6 milestone Jan 28, 2024
@home-assistant home-assistant bot added cla-signed core dependency small-pr PRs with less than 30 lines. labels Jan 28, 2024
@bdraco
Copy link
Member Author

bdraco commented Jan 28, 2024

@DCSBL Can you loosen the dep on python-homewizard-energy to aiohttp>=3.9.1 and release a new version? This is blocking us from upgrading and we need to do so urgently because this is a security release.

#108738

bdraco added a commit that referenced this pull request Jan 28, 2024
@bdraco bdraco mentioned this pull request Jan 28, 2024
20 tasks
@joostlek
Copy link
Member

@bdraco
Copy link
Member Author

bdraco commented Jan 28, 2024

Thanks @joostlek

@DCSBL
Copy link
Contributor

DCSBL commented Jan 29, 2024

Seen and started merge + bumb, sorry for inconvenience

@DCSBL
Copy link
Contributor

DCSBL commented Jan 29, 2024

New version is ready without the pinning, thanks for the heads-up both!

#109038

@bdraco
Copy link
Member Author

bdraco commented Jan 29, 2024

Thanks

@bdraco bdraco marked this pull request as ready for review January 29, 2024 07:44
@bdraco bdraco requested a review from a team as a code owner January 29, 2024 07:44
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 29, 2024 09:18
@bdraco
Copy link
Member Author

bdraco commented Jan 29, 2024

We need to hold on this for another release since 3.9.2 is not compatible with aiobotocore aio-libs/aiohttp#8098

@bdraco
Copy link
Member Author

bdraco commented Jan 29, 2024

I'll double check the websocket changes but I think this is OK as it's actually being closed instead of getting close and than hanging open now which is a good thing

@bdraco
Copy link
Member Author

bdraco commented Jan 29, 2024

Final analysis indicates HA is not affected by the two security changes in aiohttp so we can wait for aiobotocore to be fixed here. I'm going to drop the milestone. I'll retarget it as soon as the new aiohttp release is available

@bdraco bdraco removed this from the 2024.1.6 milestone Jan 29, 2024
@bdraco bdraco changed the title Bump aiohttp to 3.9.2 Bump aiohttp to 3.9.3 Jan 29, 2024
@bdraco
Copy link
Member Author

bdraco commented Jan 29, 2024

@bdraco bdraco dismissed joostlek’s stale review January 29, 2024 20:45

tested were adjusted

@bdraco bdraco added this to the 2024.1.6 milestone Jan 29, 2024
@bdraco bdraco marked this pull request as ready for review January 29, 2024 21:42
@frenck frenck merged commit 825fed8 into dev Jan 29, 2024
74 checks passed
@frenck frenck deleted the aiohttp392 branch January 29, 2024 22:15
Moustachauve pushed a commit to Moustachauve/HA-core that referenced this pull request Jan 30, 2024
frenck pushed a commit that referenced this pull request Jan 30, 2024
Co-authored-by: Joost Lekkerkerker <[email protected]>
@frenck frenck mentioned this pull request Jan 30, 2024
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Jan 31, 2024
…to v2024.1.6 (#350)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | patch | `2024.1.5` -> `2024.1.6` |

---

### Release Notes

<details>
<summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary>

### [`v2024.1.6`](https://github.com/home-assistant/core/releases/tag/2024.1.6)

[Compare Source](home-assistant/core@2024.1.5...2024.1.6)

-   Pass default SSLContext instances to Octoprint custom HTTP sessions ([@&#8203;vexofp] - [#&#8203;105351]) ([octoprint docs])
-   Reduce overhead for google calendar state updates ([@&#8203;allenporter] - [#&#8203;108133]) ([google docs])
-   Fix SleepIQ setting FootWarmer timer ([@&#8203;jmwaldrip] - [#&#8203;108433]) ([sleepiq docs])
-   Fix zha illuminance measured value mapping ([@&#8203;floriankisser] - [#&#8203;108547]) ([zha docs])
-   Bump yolink-api to 0.3.6 fix aiomqtt breaking changes ([@&#8203;matrixd2] - [#&#8203;108555]) ([yolink docs]) (dependency)
-   Update openerz-api to 0.3.0 ([@&#8203;misialq] - [#&#8203;108575]) ([openerz docs]) (dependency)
-   Bump aiovodafone to 0.5.4 ([@&#8203;chemelli74] - [#&#8203;108592]) ([vodafone_station docs]) (dependency)
-   Bump airthings-ble to 0.6.0 ([@&#8203;LaStrada] - [#&#8203;108612]) ([airthings_ble docs]) (dependency)
-   Fix alexa fails reporting the state in specific cases ([@&#8203;jbouwh] - [#&#8203;108743]) ([alexa docs])
-   Reduce log level of ZHA endpoint handler init ([@&#8203;puddly] - [#&#8203;108749]) ([zha docs])
-   Fix google_assistant climate modes might be None ([@&#8203;jbouwh] - [#&#8203;108793]) ([google_assistant docs])
-   Fix unhandled exception on humidifier intent when available_modes is None ([@&#8203;jbouwh] - [#&#8203;108802]) ([humidifier docs])
-   Fix processing supported color modes for emulated_hue ([@&#8203;jbouwh] - [#&#8203;108803]) ([emulated_hue docs])
-   Reduce log level for creating ZHA cluster handler ([@&#8203;TheJulianJES] - [#&#8203;108809]) ([zha docs])
-   Fix stalls in config flow of APCUPSD ([@&#8203;yuxincs] - [#&#8203;108931]) ([apcupsd docs])
-   Add strings to Sensirion BLE ([@&#8203;joostlek] - [#&#8203;109001]) ([sensirion_ble docs])
-   Fix entity naming for heatpump heatings in ViCare ([@&#8203;CFenner] - [#&#8203;109013]) ([vicare docs])
-   Bump aiohttp to 3.9.3 ([@&#8203;bdraco] - [#&#8203;109025]) (dependency)
-   Bump ZHA dependency zigpy to 0.60.7 ([@&#8203;puddly] - [#&#8203;109082]) ([zha docs]) (dependency)
-   Add missing abort message for Spotify ([@&#8203;joostlek] - [#&#8203;109102]) ([spotify docs])

[#&#8203;105351]: home-assistant/core#105351

[#&#8203;106970]: home-assistant/core#106970

[#&#8203;107239]: home-assistant/core#107239

[#&#8203;107365]: home-assistant/core#107365

[#&#8203;107883]: home-assistant/core#107883

[#&#8203;108133]: home-assistant/core#108133

[#&#8203;108379]: home-assistant/core#108379

[#&#8203;108433]: home-assistant/core#108433

[#&#8203;108502]: home-assistant/core#108502

[#&#8203;108547]: home-assistant/core#108547

[#&#8203;108555]: home-assistant/core#108555

[#&#8203;108575]: home-assistant/core#108575

[#&#8203;108592]: home-assistant/core#108592

[#&#8203;108612]: home-assistant/core#108612

[#&#8203;108743]: home-assistant/core#108743

[#&#8203;108749]: home-assistant/core#108749

[#&#8203;108793]: home-assistant/core#108793

[#&#8203;108802]: home-assistant/core#108802

[#&#8203;108803]: home-assistant/core#108803

[#&#8203;108809]: home-assistant/core#108809

[#&#8203;108931]: home-assistant/core#108931

[#&#8203;109001]: home-assistant/core#109001

[#&#8203;109013]: home-assistant/core#109013

[#&#8203;109025]: home-assistant/core#109025

[#&#8203;109082]: home-assistant/core#109082

[#&#8203;109102]: home-assistant/core#109102

[@&#8203;CFenner]: https://github.com/CFenner

[@&#8203;LaStrada]: https://github.com/LaStrada

[@&#8203;TheJulianJES]: https://github.com/TheJulianJES

[@&#8203;allenporter]: https://github.com/allenporter

[@&#8203;bdraco]: https://github.com/bdraco

[@&#8203;chemelli74]: https://github.com/chemelli74

[@&#8203;floriankisser]: https://github.com/floriankisser

[@&#8203;frenck]: https://github.com/frenck

[@&#8203;jbouwh]: https://github.com/jbouwh

[@&#8203;jmwaldrip]: https://github.com/jmwaldrip

[@&#8203;joostlek]: https://github.com/joostlek

[@&#8203;matrixd2]: https://github.com/matrixd2

[@&#8203;misialq]: https://github.com/misialq

[@&#8203;puddly]: https://github.com/puddly

[@&#8203;vexofp]: https://github.com/vexofp

[@&#8203;yuxincs]: https://github.com/yuxincs

[airthings_ble docs]: https://www.home-assistant.io/integrations/airthings_ble/

[alexa docs]: https://www.home-assistant.io/integrations/alexa/

[apcupsd docs]: https://www.home-assistant.io/integrations/apcupsd/

[dlna_dmr docs]: https://www.home-assistant.io/integrations/dlna_dmr/

[dlna_dms docs]: https://www.home-assistant.io/integrations/dlna_dms/

[emulated_hue docs]: https://www.home-assistant.io/integrations/emulated_hue/

[enigma2 docs]: https://www.home-assistant.io/integrations/enigma2/

[google docs]: https://www.home-assistant.io/integrations/google/

[google_assistant docs]: https://www.home-assistant.io/integrations/google_assistant/

[humidifier docs]: https://www.home-assistant.io/integrations/humidifier/

[octoprint docs]: https://www.home-assistant.io/integrations/octoprint/

[openerz docs]: https://www.home-assistant.io/integrations/openerz/

[samsungtv docs]: https://www.home-assistant.io/integrations/samsungtv/

[sensirion_ble docs]: https://www.home-assistant.io/integrations/sensirion_ble/

[shelly docs]: https://www.home-assistant.io/integrations/shelly/

[sleepiq docs]: https://www.home-assistant.io/integrations/sleepiq/

[spotify docs]: https://www.home-assistant.io/integrations/spotify/

[ssdp docs]: https://www.home-assistant.io/integrations/ssdp/

[streamlabswater docs]: https://www.home-assistant.io/integrations/streamlabswater/

[system_bridge docs]: https://www.home-assistant.io/integrations/system_bridge/

[upnp docs]: https://www.home-assistant.io/integrations/upnp/

[vicare docs]: https://www.home-assistant.io/integrations/vicare/

[vodafone_station docs]: https://www.home-assistant.io/integrations/vodafone_station/

[yeelight docs]: https://www.home-assistant.io/integrations/yeelight/

[yolink docs]: https://www.home-assistant.io/integrations/yolink/

[zha docs]: https://www.home-assistant.io/integrations/zha/

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE2MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/350
Co-authored-by: Renovate <[email protected]>
Co-committed-by: Renovate <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants