-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a repair issue for Shelly devices with unsupported firmware #109076
Add a repair issue for Shelly devices with unsupported firmware #109076
Conversation
Hey there @balloob, @bieniu, @thecode, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Tested on production, nothing blew up. Going to get the older new in box devices out of storage and test with one of them next |
I'm going to have to make the config entry manually since I can't add unsupported devices |
Going to update the firmware in the shelly app now |
Updated, and the device recovered and setup now |
It looks like we need to delete the issue on successful setup as well since the issue was still there after I updated the firmware |
I'll see if I can help finish the tests before I go to the airport. I had created 200 phantom test devices and noticed listing issues was slow #109149 |
I'm going to take a stab at writing the tests for the sleeping devices |
Thanks @chemelli74 |
Breaking change
Proposed change
Due to current architecture first implementation is not reparable. This feature will be added in future.
In a future PR we will adjust the architecture of the system to have limited support for older devices which will allow updating the firmware so the repair issue can be automatically fixed in most cases. As this requires a re-architecture, this is not available in the first iteration, and we felt it was better to present a repair issue than have users have to look for a cryptic log message.
Needs home-assistant-libs/aioshelly#483(already merged)(follow-up of #108104)
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: