Create issues for reauth flows #109105
Merged
Create issues for reauth flows #109105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
emontnemery
commented
Jan 30, 2024
Comment on lines
+807
to
+816
| ir.async_create_issue( | ||
| hass, | ||
| HA_DOMAIN, | ||
| issue_id, | ||
| data={"flow_id": result["flow_id"]}, | ||
| is_fixable=False, | ||
| issue_domain=self.domain, | ||
| severity=ir.IssueSeverity.ERROR, | ||
| translation_key="config_entry_reauth", | ||
| ) |
There was a problem hiding this comment.
My idea is that frontend knows that an issue in the homeassistant domain with translation key config_entry_reauth has a linked reauth flow.
Comment on lines
+51
to
+52
| "title": "[%key:common::config_flow::title::reauth%]", | ||
| "description": "Reauthentication is needed" |
There was a problem hiding this comment.
These will need to be adjusted or removed when we know how frontend will display these issues.
emontnemery
force-pushed
the
reauth_create_issue
branch
from
31992c8
to
6056faa
Compare
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
MartinHjelmare
approved these changes
Jan 31, 2024
|
Can be merged when there's a linked and approved frontend PR. |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Create repair issues for reauth flows
Rationale:
By showing reauth issues also in the repairs center, they should be easier for users to find
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: