-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ZHA cover inversion handling missing attributes #109151
Fix ZHA cover inversion handling missing attributes #109151
Conversation
Hey there @dmulcahey, @Adminiuga, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
…ion switch" This reverts commit 048d649.
I'll have to look at this closer later, but the attributes should be initialized for existing devices too, since the attributes are in But I guess this breaks for battery-powered covers, because we don't initialize the attributes when ZHA is reloaded there? |
I think that’s the case. I think battery ones are only during pairing. I have a way to fix this in the future I think… just need to build out the infrastructure for it. |
Proposed change
#108238 relies on the
window_covering_type
attribute, which is usually not present in the attribute cache until it is explicitly read. Similarly, inversion relies onwindow_covering_mode
.This PR ensures
None
is properly handled with both. In a future PR, existing devices should be re-initialized automatically to account for these new attributes.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: