-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update denonavr
to 0.11.6
#110231
Update denonavr
to 0.11.6
#110231
Conversation
Hey there @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
6841e35
to
3e759e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working locally for me, and can confirm it resolves ol-iver/denonavr#273 (which I was going to submit a PR for today when I saw you raised this one!)
You've contributed to HA more than me so you may know more, but in the past I was told to separate the library bump into a separate PR from the code changes. Not sure if that's a rule or just a suggestion.
|
27f73bf
to
3685f54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with my devices. Did not find any obvious regressions 👍
Breaking change
Proposed change
This PR updates denonavr library to 0.11.6 (changelog 0.11.5, changelog 0.11.6).
Additionally, it adds handling for
AvrProcessingError
exceptions and removes code which is obsolete since version0.11.5
.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: