Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update denonavr to 0.11.6 #110231

Merged
merged 4 commits into from
Feb 11, 2024
Merged

Update denonavr to 0.11.6 #110231

merged 4 commits into from
Feb 11, 2024

Conversation

ol-iver
Copy link
Contributor

@ol-iver ol-iver commented Feb 11, 2024

Breaking change

Proposed change

This PR updates denonavr library to 0.11.6 (changelog 0.11.5, changelog 0.11.6).
Additionally, it adds handling for AvrProcessingError exceptions and removes code which is obsolete since version 0.11.5.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (denonavr) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of denonavr can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign denonavr Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@dcmeglio dcmeglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working locally for me, and can confirm it resolves ol-iver/denonavr#273 (which I was going to submit a PR for today when I saw you raised this one!)

You've contributed to HA more than me so you may know more, but in the past I was told to separate the library bump into a separate PR from the code changes. Not sure if that's a rule or just a suggestion.

@ol-iver ol-iver changed the title Update denonavr to 0.11.5 Update denonavr to 0.11.6 Feb 11, 2024
@ol-iver
Copy link
Contributor Author

ol-iver commented Feb 11, 2024

0.11.5 had a regression, so there is 0.11.6 now.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with my devices. Did not find any obvious regressions 👍

@thecode thecode merged commit 0c9f948 into home-assistant:dev Feb 11, 2024
53 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants