Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swiss public transport via stations #115891

Merged
merged 8 commits into from
Jun 23, 2024
Merged

Conversation

miaucl
Copy link
Contributor

@miaucl miaucl commented Apr 20, 2024

Proposed change

Add via stations to the config of the connections. Up to 5 via stations are allowed by the api.
The legacy import via yaml is left out, as it will get removed soon has been removed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (swiss_public_transport) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of swiss_public_transport can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign swiss_public_transport Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@miaucl miaucl changed the title add via stations Add Swiss public transport via stations Apr 20, 2024
@miaucl miaucl marked this pull request as ready for review April 20, 2024 14:19
@miaucl miaucl requested a review from fabaff as a code owner April 20, 2024 14:19
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 28, 2024 14:24
@miaucl miaucl marked this pull request as ready for review April 28, 2024 21:03
@miaucl miaucl marked this pull request as ready for review June 17, 2024 12:08
@home-assistant home-assistant bot marked this pull request as draft June 18, 2024 20:40
@miaucl miaucl marked this pull request as ready for review June 19, 2024 21:08
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 20, 2024
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment left in the strings then it's good to go 👍

@home-assistant home-assistant bot marked this pull request as draft June 23, 2024 11:08
@miaucl miaucl marked this pull request as ready for review June 23, 2024 17:19
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @miaucl 👍

@gjohansson-ST gjohansson-ST merged commit 7efd107 into home-assistant:dev Jun 23, 2024
25 checks passed
@miaucl miaucl deleted the spt_via branch June 23, 2024 17:45
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants