Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BMW tire pressure sensors #120949

Merged
merged 3 commits into from
Jul 6, 2024
Merged

Conversation

rikroe
Copy link
Contributor

@rikroe rikroe commented Jul 1, 2024

Proposed change

This PR adds 8 sensors to BMW connected drive: (current) tire pressure per tire and target pressure (disabled by default).

Required refactoring of the sensor's way of getting data from the vehicle object (7cf2c6f). If this should be moved to a separate PR, please let me know.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jul 1, 2024

Hey there @gerard33, mind taking a look at this pull request as it has been labeled with an integration (bmw_connected_drive) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of bmw_connected_drive can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign bmw_connected_drive Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@rikroe rikroe changed the title Add BMW current and target tire pressure sensors Add BMW tire pressure sensors Jul 1, 2024
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 4, 2024
@home-assistant
Copy link

home-assistant bot commented Jul 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft July 5, 2024 07:53
@edenhaus edenhaus removed the smash Indicator this PR is close to finish for merging or closing label Jul 5, 2024
@rikroe rikroe marked this pull request as ready for review July 6, 2024 15:46
@home-assistant home-assistant bot requested a review from edenhaus July 6, 2024 15:46
@rikroe
Copy link
Contributor Author

rikroe commented Jul 6, 2024

After rebasing there is something not working as desired. Will check.

@frenck frenck marked this pull request as draft July 6, 2024 16:05
@rikroe
Copy link
Contributor Author

rikroe commented Jul 6, 2024

Forgot to run generate translations between rebase and snapshot upgrade. Fixed now.

@rikroe rikroe marked this pull request as ready for review July 6, 2024 16:13
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rikroe 👍

../Frenck

@frenck frenck dismissed edenhaus’s stale review July 6, 2024 16:19

Comment addressed

@frenck frenck merged commit 131d9ec into home-assistant:dev Jul 6, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants